(#1028) docs update - fix emojis #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replace ⚙️ with unicode gear ⚙ emoticon - replace 💾 with unicode floppy disk 💾 emoticon
- replace ⚙️ with unicode gear ⚙ emoticon - replace 💾 with unicode floppy disk 💾 emoticon - replace 🔍 with unicode magnifying glass tilted left 🔍 emoticon
- replace ⚙️ with unicode gear ⚙ emoticon - replace 💾 with unicode floppy disk 💾 emoticon
- replace 💾 with unicode floppy disk 💾 emoticon - replace ➕ with unicode plus sign ➕ emoticon - replace 📆 with unicode calendar 📅 emoticon
- replace ➕ with unicode plus sign ➕ emoticon - replace 🗑️ with unicode wastebasket 🗑 emoticon
- replace ⚙️ with unicode gear ⚙ emoticon
- replace ⚙️ with unicode gear ⚙ emoticon
- replace ⚙️ with unicode gear ⚙ emoticon
- replace ⚙️ with unicode gear ⚙ emoticon
- replace 🔍 with unicode magnifying glass tilted left 🔍 emoticon
|
@st3phhays I've added you as a reviewer here. I'm unsure whether these docs are templated outside of docs, and the templates need updated, or whether these changes are good as they stand. |
|
@LeaDevelop thanks for the PR! |
st3phhays
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
This LGTM but I did want to mention, in this comment, we had made the decision to remove emojis entirely or move to Font Awesome due to accessibility concerns and consistency in choco-theme. This PR definitely is a win in that we don't have broken emojis in our docs anymore, but I think we need to take a look at this issue again when we start our scope of work for accessibility.
@LeaDevelop Thank you for taking the time to get this done!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Emotions (
:gear:,:floppy_disk:,:mag:,:heavy_plus_sign:,:calendar,:wastebasket:) were replaced with Unicode ones (⚙💾🔍➕📅🗑).Motivation and Context
Motivation was to improve the user experience and ensure consistent visual representation across different platforms and devices. Previously, emoticons were not displaying, which could lead to confusion or misinterpretation of the documentation.
Testing
Pages that were validated:
Change Types Made
Change Checklist